The purpose of our analysis is to identify the effect of l-carnitine (LC) and l-acetyl carnitine (LAC) on the semen parameters of men with idiopathic oligoasthenoteratozoospermia (iOAT). We performed a comprehensive search to ascertain all the trials about LC and LAC in the treatment of iOAT and compared the results, including percentage of total sperm motility, sperm concentration, percentage of forward sperm motility, semen volume, percentage of atypical forms, total motile spermatozoa, forward motile spermatozoa and the number of pregnancies between the two groups that treated with LC + LAC or placebo respectively. Seven randomised controlled trials (RCTs) involving 693 patients were included in our analysis. We found that patients who treated with LC and LAC had significantly increased the percentage of forward sperm motility (MD 6.98; 95% CI 1.06-12.90; p = .02), total motile spermatozoa (MD 16.45; 95% CI 8.10-24.79; p = .0001), forward motile spermatozoa (MD 13.01; 95% CI 11.08-14.94; p < .00001) and the number of pregnancies (OR 3.76; 95% CI 1.66-8.50; p = .002). However, no significant differences were found in other semen indicators between the two groups. LC and LAC can significantly increase part of the semen parameters. The combination therapy of LC and LAC is effective in the men with iOAT.